Various fixes - Githubissues

certtools / intelmq-manager

IntelMQ Manager is a graphical interface to manage configurations for IntelMQ framework.

https://docs.intelmq.org/latest/user/manager/

102 stars 56 forks source link

Various fixes #276

Closed monoidic closed 3 years ago

monoidic commented 3 years ago

This PR:

fixes #152 by not permitting the user to create a bot with an ID collision
fixes #212 by asking the user for confirmation to exit the page in case they have unsaved changes
fixes #275 (though it doesn't seem exploitable)
fixes editing the default bot attributes
replaces some usage of the this variable with an equivalent value for clarity
sets use strict in configs.js and monitor.js, with a small associated fix in the latter

ghost commented 3 years ago

Wow, thanks again!

monoidic commented 3 years ago

Added some variable declarations that were missing, and fixed an UI/UX issue where clicking on the glyph inside of the start/stop/reload bot buttons would not work properly.

ghost commented 3 years ago

Are there more fixes coming? :)

As soon as you deem it ready, we can release version 3.0.1.

monoidic commented 3 years ago

I think that should be it for now.

monoidic commented 3 years ago

... :P

ghost commented 3 years ago

thanks! also merged into maintenance for the 3.0.1 release