Upgrade test fails because of missing bot definition

[ghost]

TASK [Run file-input bot once] *************************************************
fatal: [default]: FAILED! => {"changed": true, "cmd": ["intelmqctl", "run", "file-input", "process"], "delta": "0:00:00.426244", "end": "2021-09-01 16:46:28.369527", "msg": "non-zero return code", "rc": 2, "start": "2021-09-01 16:46:27.943283", "stderr": "usage: intelmqctl run [-h] [--loglevel [{DEBUG,INFO,WARNING,ERROR,CRITICAL}]]\n                      {cymru-whois-expert,deduplicator-expert,feodo-tracker-browse-collector,feodo-tracker-browse-parser,file-output,gethostbyname-1-expert,gethostbyname-2-expert,malc0de-parser,malc0de-windows-format-collector,spamhaus-drop-collector,spamhaus-drop-parser,taxonomy-expert,url2fqdn-expert}\n                      {console,message,process} ...\nintelmqctl run: error: argument bot_id: invalid choice: 'file-input' (choose from 'cymru-whois-expert', 'deduplicator-expert', 'feodo-tracker-browse-collector', 'feodo-tracker-browse-parser', 'file-output', 'gethostbyname-1-expert', 'gethostbyname-2-expert', 'malc0de-parser', 'malc0de-windows-format-collector', 'spamhaus-drop-collector', 'spamhaus-drop-parser', 'taxonomy-expert', 'url2fqdn-expert')", "stderr_lines": ["usage: intelmqctl run [-h] [--loglevel [{DEBUG,INFO,WARNING,ERROR,CRITICAL}]]", "                      {cymru-whois-expert,deduplicator-expert,feodo-tracker-browse-collector,feodo-tracker-browse-parser,file-output,gethostbyname-1-expert,gethostbyname-2-expert,malc0de-parser,malc0de-windows-format-collector,spamhaus-drop-collector,spamhaus-drop-parser,taxonomy-expert,url2fqdn-expert}", "                      {console,message,process} ...", "intelmqctl run: error: argument bot_id: invalid choice: 'file-input' (choose from 'cymru-whois-expert', 'deduplicator-expert', 'feodo-tracker-browse-collector', 'feodo-tracker-browse-parser', 'file-output', 'gethostbyname-1-expert', 'gethostbyname-2-expert', 'malc0de-parser', 'malc0de-windows-format-collector', 'spamhaus-drop-collector', 'spamhaus-drop-parser', 'taxonomy-expert', 'url2fqdn-expert')"], "stdout": "", "stdout_lines": []}

relevant part is:

intelmqctl run: error: argument bot_id: invalid choice: 'file-input

[ghost]

Hm, I can not reproduce this error

[ghost]

Hm, still have it, using df1b6d77d7ebb9ae07c2b1cf84eb48c0f90aca4b

[b1rger]

But the tests also run fine in the github action. You get the error when running using vagrant up? Which machine?

[ghost]

Yes, with vagrant up. I only have the issue with the Upgrade test.

[b1rger]

Ah, oke, the upgrade-test machine, I didn't realize you meant that. Yes, that one is not tested by github actions and I can reproduce the error with that. I guess we hit the same problem we discussed on Monday: the ansible recipies copy a custom runtime.conf on to the machine, but the intelmq packages ship a runtime.yaml without a file-iput. A solution would probably be to run the recommendes manual upgrade steps in the ansible/upgrade-tests.yml file.

[sebix]

As the stable version is 3.0 now, we can drop the old-style configuration and just ship a new runtime.yml. makes the setup simpler and probably solved this bug as well.