certtools / intelmq

IntelMQ is a solution for IT security teams for collecting and processing security feeds using a message queuing protocol.
https://docs.intelmq.org/latest/
GNU Affero General Public License v3.0
977 stars 297 forks source link

Fixed #2125 #2386

Closed sebkuf closed 1 year ago

sebkuf commented 1 year ago

Fixes #2125, fix syntax in separate-raws-table.sql

sebix commented 1 year ago

@sebkuf Can you please include in the commit message either fixes #2386 or fixes certtools/intelmq#2386 / remove the :, so that the commit is linked to the issue and closes it once merged? See also https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

And the commit message could be more descriptive too, for example

fix syntax in separate-raws-table.sql  // short description

contrib/eventdb/separate-raws-table.sql was missing some commas in the column list, breaking SQL syntax
this adds commas to all columns  // long description

fixes certtools/intelmq#2386  // linking the issue
kamil-certat commented 1 year ago

Please update the commit message and add a short changelog entry