certtools / intelmq

IntelMQ is a solution for IT security teams for collecting and processing security feeds using a message queuing protocol.
https://docs.intelmq.org/latest/
GNU Affero General Public License v3.0
972 stars 295 forks source link

FIX: RIPE expert: handle unknown response for non-ASN types #2461

Closed monoidic closed 7 months ago

monoidic commented 7 months ago

Currently, the RIPE bot successfully handles "No abuse contact found for" messages in response to ASNs, but not for IPs. An example of this would be the address 2001:470:1:c84::12e, which is from a range assigned by ARIN. This PR removes the filter on only checking for these types of messages on ASNs, allowing for IPs to not cause errors in the bot.

kamil-certat commented 7 months ago

Thanks, it looks good to me!. Do you think it would be possible to easily add a test for that case? And a short changelog entry?

monoidic commented 7 months ago

Thanks, it looks good to me!. Do you think it would be possible to easily add a test for that case? And a short changelog entry?

Certainly.

aaronkaplan commented 7 months ago

Thank you, @monoidic