FQDN with trailing dot or not?

[sebix]

The current implementation allows bots variants, with and without the trailing dot for the root zone. Sanitize does not add or remove it.

>>> intelmq.lib.harmonization.FQDN.is_valid(u'foobar.example.')
True
>>> intelmq.lib.harmonization.FQDN.is_valid(u'foobar.example')
True
>>> intelmq.lib.harmonization.FQDN.sanitize(u'foobar.example')
u'foobar.example'
>>> intelmq.lib.harmonization.FQDN.sanitize(u'foobar.example.')
u'foobar.example.'

This can potentially lead to duplicates.

Which variant do you prefer?

[SYNchroACK]

'foobar.example'

[robcza]

Talking of indicators of compromise I think foobar.example and foobar.example. carry exactly the same information. As I would expect from IntelMQ, that the output is normalized I prefer the variant, when sanitization always produces fqdn without trailing dot.

[sebix]

@aaronkaplan What do you think here?

[aaronkaplan]

On 20 Oct 2015, at 17:12, Sebastian notifications@github.com wrote:

@aaronkaplan What do you think here?

Robert’s proposal is fine for me. It’s easy to rtrim(‘.’) at the end.

[sebix]

Ok, we have a consensus here. Trailing dot is not allowed and will be removed in sanitation.

[aaronkaplan]

On 20 Oct 2015, at 17:18, Sebastian notifications@github.com wrote:

Ok, we have a consensus here. Trailing dot is not allowed and will be removed in sanitation.

Yes