certtools / intelmq

IntelMQ is a solution for IT security teams for collecting and processing security feeds using a message queuing protocol.
https://docs.intelmq.org/latest/
GNU Affero General Public License v3.0
976 stars 296 forks source link

Security: Imbox (and other libs) do not validate certificates #532

Closed dmth closed 8 years ago

dmth commented 8 years ago

The colleagues from Abusehelper realised some flaws concerning their SSL implementation: https://github.com/abusesa/abusehelper/blob/master/docs/SECURITY-2016-01.md

@bernhard-herzog reviewed some parts of IntelMQ.

The library "imbox", which is used by the Mail-Collectors, does not validate the certificate of the IMAP Server. It is not possible to force the library to do so.

We also checked:

To discuss:

dmth commented 8 years ago

Opened an Issue at IMBOX: https://github.com/martinrusev/imbox/issues/68

sebix commented 8 years ago

Also also would like to see this fixed upstream. Creating our own library is much more work than patching the existing code. Thanks for bringing this upstream.

dmth commented 8 years ago

We created a PR for this issue in IMBOX. This one was merged upstream. A new imbox release should fix the issues with imbox.

sleekxmpp is still unresolved

dmth commented 8 years ago

There is a new Imbox-Relase: https://pypi.python.org/pypi/imbox/0.8.5