cervinakuy / KitPvP

An all-in-one battle plugin built using customizable kits and features.
https://www.spigotmc.org/resources/27107/
104 stars 50 forks source link

Interacting with a KitPVP sign brings up the sign editing menu in 1.20.x #245

Closed whizvox closed 1 month ago

whizvox commented 5 months ago

Description of the bug In the 1.20 update, signs can now be edited by right-clicking on them. For KitPVP's interactable signs, right-clicking on them will do whatever action you gave it, but it'll also bring up the sign-editing menu. If you have build permissions and exit the menu, the top line's color formatting will be removed, and the sign will lose its functionality. If you don't have build permissions and use something like WorldGuard, exiting the menu will display a "Sorry, but you can't place that block here." message.

I think with the build permissions, Minecraft will remove the original sign and place a new one to achieve the effect of "editing" the sign, hence why the sign seems to lose its functionality.

Screenshot of /kp debug 2024-06-03_10 18 46

Additional screenshots or video (if applicable) Right-clicking on an interactable sign: 2024-06-03_10 20 08

If you have build permissions: 2024-06-03_10 20 19

If you don't have build permissions: 2024-06-03_10 31 03

Pastebin.com of any relevant .yml files (if applicable) n/a

cervinakuy commented 5 months ago

Thanks for reporting. #248 currently working on a fix. Will follow up as things progress

cervinakuy commented 1 month ago

Thanks, fixed in 768a7a9 and will be included in next update, see #266.