search

ceryliae / DnDAppFiles

Files for the Fifth Edition apps by Lion's Den
614 stars 549 forks source link

Various updates #188

Closed 153957 closed 8 years ago

153957 commented 8 years ago

For consistency replaced all <text> </text> by <text />. Fixed a sentence in the README. Fixed a missing opening bracket in the Templates. Update the Compendiums using the new script.

afluffygrue commented 8 years ago

I remember doing the intentionally because didn't do what I wanted, but I can't recall what that was.

Thanks, Dan

Typed with my thumbs.

On Jan 2, 2016, at 12:15 PM, Arne de Laat notifications@github.com wrote:

For consistency replaced all by . Fixed a sentence in the README. Fixed a missing opening bracket in the Templates. Update the Compendiums using the new script.

You can view, comment on, or merge this pull request online at:

https://github.com/ceryliae/DnDAppFiles/pull/188

Commit Summary

Fix typo in Templates.xml Fix sentence in README Replace <text> </text> by <text /> Regenerate Compendiums using script. File Changes

M Archive/Class.xml (3201) M Bestiary/Hoard of the Dragon Queen Bestiary.xml (19) M Bestiary/Monster Manual Bestiary.xml (176)
M Bestiary/Out of the Abyss.xml (40) M Bestiary/Phandelver Bestiary.xml (6) M Bestiary/Player Bestiary.xml (18) M Bestiary/Princes of the Apocalypse Bestiary.xml (60) M Character/Backgrounds.xml (43) M Character/Classes.xml (820) M Character/Feats.xml (373) M Character/Mulmaster Backgrounds.xml (1) M Character/Races.xml (40) M Compendiums/Bestiary Compendium.xml (30135) M Compendiums/Character Compendium.xml (18111) M Compendiums/Full Compendium.xml (84312) M Compendiums/Items Compendium.xml (27599) M Compendiums/Spells Compendium.xml (3657) M Items/Futuristic Items.xml (148) M Items/Magic Items.xml (3592) M Items/Modern Items.xml (800) M Items/Mundane Items.xml (710) M Items/Renaissance Items.xml (126) M Items/Valuable Items.xml (200) M README.md (5) M Russian/Monster Manual Bestiary.xml (176) M Russian/Russian Spells.xml (6) M Spells/Demon Summoning.xml (26) M Spells/EE Spells.xml (246) M Spells/Modern Spells.xml (30) M Spells/PHB Spells.xml (1560) M Templates.xml (17) M Unearthed Arcana/UA Races.xml (20) Patch Links:

https://github.com/ceryliae/DnDAppFiles/pull/188.patch https://github.com/ceryliae/DnDAppFiles/pull/188.diff — Reply to this email directly or view it on GitHub.

153957 commented 8 years ago

This comment was written in some of the files:

Due to a bug in D20 Fight Club app importing, "<text/>" has been replaced with "<text> </text>" for line breaks

These empty text tags are used for blank lines. There were already some <text /> tags in the Compendium files and those looked fine in the DM app, I did not check in Fight Club yet..

ceryliae commented 8 years ago

Can you check these files to see if works before I merge this request?

I think the bug has been fixed by now, but I don't know. On Sat, Jan 2, 2016 at 12:58 PM Arne de Laat notifications@github.com wrote:

This comment was written in some of the files:

Due to a bug in D20 Fight Club app importing, "" has been replaced with " " for line breaks

These empty text tags are used for blank lines. There were already some <text /> tags in the Compendium files and those looked fine in the DM app, I did not check in Fight Club yet..

— Reply to this email directly or view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/188#issuecomment-168427829.

153957 commented 8 years ago

I just installed Fight Club and it looks fine too.