search

ceryliae / DnDAppFiles

Files for the Fifth Edition apps by Lion's Den
614 stars 549 forks source link

Fixed attack rolls that mismatched their descriptions #225

Closed NeilMartin closed 8 years ago

NeilMartin commented 8 years ago

I wrote a parser that constructed the encoded dice roll text '|1|1d4-1' from the original text attack text 'Melee Weapon Attack: +1 to hit, reach 5 ft., one target. Hit: 1 (1d4 - 1) slashing damage.'

Then I fixed all of the mismatches I found in Monster Manual Bestiary.xml

ceryliae commented 8 years ago

Do you have plans to do this to the other bestiary files?

NeilMartin commented 8 years ago

Sure, I'll scan the others.

On 31 July 2016 at 21:43, ceryliae notifications@github.com wrote:

Do you have plans to do this to the other bestiary files?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#issuecomment-236488356, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDJriPoOjxKnyxudlKOnb8TWLsKdv5Aks5qbXmEgaJpZM4JY4db .

neil_martin_vanpubs http://www.vanpubs.com

ceryliae commented 8 years ago

One other question:

You're going under the assumption that what is written in the text is right, and what is written for the code for the roll is wrong. How do we know it's not the other way around?

NeilMartin commented 8 years ago

I own the monster manual and I checked. In all cases the text was correct and the attack block was wrong. However, I do not own the other bestiaries.

On 31 July 2016 at 23:14, ceryliae notifications@github.com wrote:

One other question:

You're going under the assumption that what is written in the text is right, and what is written for the code for the roll is wrong. How do we know it's not the other way around?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#issuecomment-236497558, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDJrs44BYdKQFA1Jo2i_F4W7htLG0vYks5qbY6sgaJpZM4JY4db .

neil_martin_vanpubs http://www.vanpubs.com

ceryliae commented 8 years ago

I'll take your word for it. Thanks for the contribution.

NeilMartin commented 8 years ago

Do you want me to push the other mismatches? Assuming the text is right and the attack block is wrong? I can't confirm those though.

On 31 July 2016 at 23:59, ceryliae notifications@github.com wrote:

Merged #225 https://github.com/ceryliae/DnDAppFiles/pull/225.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#event-740585965, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDJri3X8_CAiI9-AYWtxUyNvcYsmC3Dks5qbZk4gaJpZM4JY4db .

neil_martin_vanpubs http://www.vanpubs.com

ceryliae commented 8 years ago

Didn't you already?

https://github.com/ceryliae/DnDAppFiles/commit/0dba468 On Mon, Aug 1, 2016 at 12:01 AM NeilMartin notifications@github.com wrote:

Do you want me to push the other mismatches? Assuming the text is right and the attack block is wrong? I can't confirm those though.

On 31 July 2016 at 23:59, ceryliae notifications@github.com wrote:

Merged #225 https://github.com/ceryliae/DnDAppFiles/pull/225.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#event-740585965, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABDJri3X8_CAiI9-AYWtxUyNvcYsmC3Dks5qbZk4gaJpZM4JY4db

.

neil_martin_vanpubs http://www.vanpubs.com

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#issuecomment-236504173, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzdawmbx_NbAnaT1bVhKI5E2NsHDLfQks5qbZnXgaJpZM4JY4db .

NeilMartin commented 8 years ago

no, only just made the changes. I'll make another pull request.

ceryliae commented 8 years ago

Alrigjt, sorry about that. Long day. On Mon, Aug 1, 2016 at 12:03 AM NeilMartin notifications@github.com wrote:

no, only just made the changes. I'll make another pull request.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/ceryliae/DnDAppFiles/pull/225#issuecomment-236504419, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzda7SndzhnYY1mK8bGGo2_-niWNHttks5qbZo2gaJpZM4JY4db .