cesanta / mongoose-os

Mongoose OS - an IoT Firmware Development Framework. Supported microcontrollers: ESP32, ESP8266, CC3220, CC3200, STM32F4, STM32L4, STM32F7. Amazon AWS IoT, Microsoft Azure, Google IoT Core integrated. Code in C or JavaScript.
https://mongoose-os.com
Other
2.51k stars 429 forks source link

fix for issue 605, CMakeLists.txt for esp32c3 and esp32 shared #606

Closed a2800276 closed 1 year ago

a2800276 commented 1 year ago

The idea behind the previous PR was to reduce redundancy between esp32 and esp32c3 since their CMakeLists.txt were identical. Unfortunately, the 'include' stub of both should have also been identical, but weren't. And I did not test building for esp32c3.

I tested now as follows:

$ mos update latest
$ mos clone https://github.com/mongoose-os-apps/demo-js app1
$ mos build ... --platform esp32 # succeeds
$ mos build ... --platform esp32c3 #fails 
# apply this PR
$ rm -rf build
$ mos build ... --platform esp32c3 #succeeds
$ mos build ... --platform esp32 # succeeds

I'm not sure how you typically go about testing the build system...

https://github.com/cesanta/mongoose-os/issues/605