cesanta / mongoose-wizard

1 stars 1 forks source link

Wizard file upload not terminating #23

Open dvosully opened 1 month ago

dvosully commented 1 month ago

A recent update to add an alignment to file writes has meant file uploads may not complete successfully. Identified when trying to do an OTA firmware update which never completed, tracing revealed that in handle_uploads() the us->received never reached the us->expected when the file finished transmission, and the close_uploaded_file() callback was never executed. Changing the alignment variable to 1 instead of 32 has stopped this fault from manifesting for me, but obviously that removes the point of the alignment for targets that require it.

cpq commented 4 days ago

Fixed, please verify!

Note that the new wizard is pushed. The old wizard is accessible at https://mongoose.ws/wizard1/ - we'll keep that URL for some transition time