search

cesaraustralia / Dispersal.jl

Tools for simulating organism dispersal
Other
21 stars 3 forks source link

doc typos and Examples (in test) with DimensionalData and Aux #79

Open virgile-baudrot opened 3 years ago

virgile-baudrot commented 3 years ago

add examples in test, but maybe would be better to add in example of doc.

rafaqz commented 3 years ago

Did you want this merged? it's marked work in progress

virgile-baudrot commented 3 years ago

Yes, my idea was to propose an example to show a simple example that convert a 3D array into a DimArray since a 3D array are no more supported as aux. So the most important is that:

suit =  reshape(
        repeat(
        [1.0 1.0 2.0;
        2.0 2.0 0.5;
        1.0 1.0 0.5],3), (3,3,3))

 suit_DD = DimArray(suit, (X, Y, Ti));

But maybe it's better within Documentation than in test, this is why I used draft PR

rafaqz commented 3 years ago

Ok thats better for the docs then - either DynamicGrids.jl or here, I'm not sure.

Those kinds of tests are all in DynamicGrids.jl too.

rafaqz commented 3 years ago

Also I would deal with those typos and the examples separately, good to just get those fixes merged.