Kernel

[virgile-baudrot]

Description

Additional kernels: Geometric, Gaussian and Bivariate Student Formulation founds in Nathan 2012, "Dispersal kernels: review" from the book Dispersal Ecology and Evolution (2012) and Walker et al. (2019) "A Spatio-Temporal Exposure-Hazard Model for Assessing Biological Risk and Impact"

❓ How (where) to cite the sources?

Changes (choose one only, with x or click after creating PR):

• [x] New formulation/rule
• [ ] Documentation
• [ ] Bug fix for existing rules (non-breaking syntax)
• [ ] Minor change to existing rules (no breaks to old syntax)
• [ ] Major change to existing rules (breaking syntax, needs a breaking version bump)

Checklist:

• [x] My code follows the BlueStyle style guide
• [x] My code is commented with explanations of anything hard to understand
• [x] There are no unnecessary or unrelated code changes included in this PR
• [x] There are no dependencies added: if so, please consider if they are necessary and explain why they are required

For bugfixes

• [ ] My PR addresses a single bug/connected group of bugs
• [ ] I have included a test that will ensure the bug does not reoccur

For new Rules

• [x] My PR is limited to a clear theme/conceptual unit (otherwise make multiple PRs that can be discussed separately).
• [x] New rules have tests in a file of the same name as the rule file, e.g. /test/newrulename.jl
• [ ] I have cited the source of the new formulation/s, if applicable
• [x] I have added a documentation string to formulation struct/s, and added an entry in the docs

[virgile-baudrot]

drop the Kernel from the end, so you just do formulation=Gaussian(a)

I thought about that also. For Gaussian and Geometric it's working. But we have ExponentialKernel, ExponentialGrowth and ExponentialMortality... what makes many exponential, and why calling one Exponential and not the other

[rafaqz]

That's a good point. Exponential needs to be clarified. Geometric is also the same name as Distributions.Geometric - so maybe leaving Kernel on the end is better.

[rafaqz]

Any movement on this one virgile? Youve probably been busy. But great to have it in the package for submission

[virgile-baudrot]

I made some updates on type of wirtting equations. Also I added Weibull kernel which is very use for pollen dispersal I removed BivarianteStudent, I'm not fully sure about the mathematical formulation in Nathan et al.

[rafaqz]

Also your commits are a bit messed up with some of my commits somehow, and your mortality tests. Might need to start a new branch from master, recommit the kernel files, and push here to this branch again.

When working on a PR you should always rebase it against master and other branches, instead of merge. rebase just rewrites all your commits at the end.

[virgile-baudrot]

arrff, sorry for that. I made a change on my forks forgetting it follows the PR here

I'm doing a new branch base on the master for kernel... come in few minutes

[virgile-baudrot]

@rafaqz how do I PR here with a this new branch kernel_PR which is on my fork? Should I start a new PR and close this one?

[rafaqz]

You can push another branch to this one with --force

Or start a new PR, up to you.

[virgile-baudrot]

move to #98