The Resizer virtual functor is useless without a virtual destructor.

cesarblum / sizegripitem

A size grip QGraphicsItem for interactive resizing.

Other

30 stars 19 forks source link

The Resizer virtual functor is useless without a virtual destructor. #3

Open KubaO opened 8 years ago

KubaO commented 8 years ago

The Resizer implements a virtual functor. As such, it must include a virtual destructor. In C++11 code, instead of a Resizer one should use std::function<void(QGraphicsItem*,const QRectF&)>.

graeioume commented 8 years ago

Adding the destructor / ~Resizer() {} / as recommended squelched a number of warnings I was receiving about unused parameters caused by overloaded functions.