search

cesardeazevedo / react-native-bottom-sheet-behavior

react-native wrapper for android BottomSheetBehavior
MIT License
1.16k stars 114 forks source link

Null pointer exception shouldInterceptTouchEvent #42

Open kristfal opened 6 years ago

kristfal commented 6 years ago

We’re seeing the following crashes in production.

It seems to be a race condition as it’s hitting across a wide range of OS versions and devices.

com.bottomsheetbehavior.RNBottomSheetBehavior.onInterceptTouchEvent RNBottomSheetBehavior.java - line 247

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.support.v4.widget.ViewDragHelper.shouldInterceptTouchEvent(android.view.MotionEvent)' on a null object reference

1 com.bottomsheetbehavior.RNBottomSheetBehavior.onInterceptTouchEvent RNBottomSheetBehavior.java:247 2 android.support.design.widget.CoordinatorLayout.resetTouchBehaviors CoordinatorLayout.java:394

(Pardon the poorly formatted code, posting from mobile)

Update: Just a FYI, we’re running on 27.0.2 support lib.

kristfal commented 6 years ago

Looking at the code, this seems very similar to #40. I can open a PR with the same workaround here if needed.

cesardeazevedo commented 6 years ago

Awesome, if you fixed, and you haven't experienced any crashes, just send a pull request, i just haven't tried to to reproduce it yet, since it's hard to reproduce race conditions.

kristfal commented 6 years ago

Hey,

We’ll put our fork in production this Tuesday Wednesday. I’ll open a PR when/if we see the issue fixed.