cesardeazevedo / react-native-collapsing-toolbar

react-native wrapper for android CollapsingToolbarLayout
MIT License
293 stars 33 forks source link

Mention in readme that compileSdkVersion should be 25 #11

Closed Noitidart closed 6 years ago

Noitidart commented 6 years ago

Hi there,

Thanks for such awesome awesome modules!! Im still learning to write java component. I did my first edits here in react-native android prompt - https://github.com/shimohq/react-native-prompt-android/pull/31

But anwyays, for this module we have to update android/app.build.gradle compileSdkVersion 25. By default it is 23. I had to change to 25 otherwise I get the below errors:

:app:processDebugResources
C:\Users\Mercurius\Documents\GitHub\trustedplatform_android\android\app\build\intermediates\res\merged\debug\values-v24\values-v24.xml:3: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.

C:\Users\Mercurius\Documents\GitHub\trustedplatform_android\android\app\build\intermediates\res\merged\debug\values-v24\values-v24.xml:4: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.

C:\Users\Mercurius\Documents\GitHub\trustedplatform_android\android\app\build\intermediates\res\merged\debug\values-v24\values-v24.xml:3: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.

C:\Users\Mercurius\Documents\GitHub\trustedplatform_android\android\app\build\intermediates\res\merged\debug\values-v24\values-v24.xml:4: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.

My build fails for that. Do you know how to fix?

cesardeazevedo commented 6 years ago

yes, you need to use to use the compileSdkVersion 25 otherwise it won't work, i am not sure if there's a way to work with 23.

Do you have other problems using 25?

Noitidart commented 6 years ago

Thanks so much for super fast reply. Nope just that problem. :) I'll PR the update to readme soon. :)