search

cesardeazevedo / react-native-nested-scroll-view

react-native wrapper for android NestedScrollView
MIT License
88 stars 36 forks source link

Fix #12 #13

Closed mikeevstropov closed 6 years ago

cesardeazevedo commented 6 years ago

Thanks for the contribution, but you based on the ReactViewGroup.java and not from ReactScrollView.java, they did much more changes on the ReactScrollView.java, you can see here https://github.com/facebook/react-native/commit/5180995666051cc047b5828b2b6d45802b1c7b8b

The getOrCreateReactViewBackground function was completely removed, and we should the follow the exact ReactScrollView.java since it is already a copy from it.

I was just about to push it anyway, but thanks for the contribution.

mikeevstropov commented 6 years ago

Ok. Im not a Java developer, but commit was fix an error in #12 So now it works in 0.51. Anyway thank you for amazing library which save my time!