search

cesardeazevedo / sails-hook-sequelize-blueprints

Sails blueprints for sequelize ORM
MIT License
32 stars 19 forks source link

Develop #10

Closed jesusbv closed 8 years ago

jesusbv commented 8 years ago

This is our proposal (Beatriz HA and me) for the M-M through associations.

We introduce the to key on the belongsToMany association so we can populate/add/remove the target model and the through model itself with that option.

Please, don't hesitate to ask anything

cesardeazevedo commented 8 years ago

Thanks for awesome contribution,

I realized that the relation between affiliation and user was broken, i fixed at d27b15cb6a984137cf2ff35448556f530ab04573,

I think you should write some unit test to make sure that everything is working and will not break in the future, something like this, https://github.com/cesardeazevedo/sails-hook-sequelize-blueprints/blob/master/test/unit/controllers/Blueprint.test.js#L124-L135

Thank you very much.

jesusbv commented 8 years ago

Cool you liked, sorry for the lack of test

we did some automated and some in postman

I was assigned different project so totally forgot this team said they could use the feature so glad you like it

cesardeazevedo commented 8 years ago

It's been almost a year, hahaha, don't worry about that.