search

cesards / SuperImageView

Crop and Rounded Corners added to an ImageView.
MIT License
654 stars 111 forks source link

Crash if no drawable specified #17

Closed chriswiesner closed 6 years ago

chriswiesner commented 8 years ago

at com.cesards.cropimageview.CropImageView.computeImageMatrix(CropImageView.java:119)

causes crash if src is not specified in xml. So using an Image loading library does not work. would suggest to add a null-check for the drawable

MBratkowski commented 8 years ago

+1

jczerski commented 8 years ago

+1

yagi2 commented 8 years ago

+1

cesards commented 8 years ago

I owe you two beers each.I'll upload the new version to bintray next week

david-serrano commented 6 years ago

@cesards could the issue referenced here https://github.com/cesards/CropImageView/issues/26 be a regression on this past issue?

cesards commented 6 years ago

Fixed in the next version.

cesards commented 6 years ago

BTW, sorry about this:

I owe you two beers each.I'll upload the new version to bintray next week

We all know LATER = NEVER

It was an easy fix but I left the library in a limbo of maintenance :-(

Back to work on al the issues. Let me know if in any case, you are getting errors after the new release.