cesargb / laravel-magiclink

Create link for authenticate in Laravel without password or get private content
MIT License
385 stars 44 forks source link

Add urlencoding to the colon in the magiclink url #102

Closed jamesdb closed 12 months ago

jamesdb commented 1 year ago

Thanks for the great package @cesargb, we have been using it with great success! 🙂

We have recently encountered an issue where certain email security products (Barracuda Sentinel for example) are invalidating the links by stripping out the : and everything after it, which means our links are missing the token entirely.

I believe if we were to urlencode() the separator the issue would no longer occur. 🤞

It should be safe to do as Laravel will urldecode any route parameters, which would transform the %3A to : as before.

I've been running the changes on a local branch and i haven't noticed any issues. 👍

Build timing out, but the tests are passing locally:

Screenshot 2023-09-11 at 10 26 42