cesargb / laravel-magiclink

Create link for authenticate in Laravel without password or get private content
MIT License
385 stars 44 forks source link

Action Serialization with Postgres #21

Closed dannydinges closed 4 years ago

dannydinges commented 4 years ago

Running into an issue with the serialized string being store in Postgres. The text datatype seems to not like the escaping in the serialized string. The following seems to be the same issue.

https://github.com/Crinsane/LaravelShoppingcart/issues/362

dannydinges commented 4 years ago

I think the solution to this is to json_encode/json_decode for inserting and pulling from the DB. Also have you considered using Illuminate\Queue\SerializesModels on the Action classes?

cesargb commented 4 years ago

@dannydinges I need time to test this issue. Other option is encode in base64 after to save in database.

dannydinges commented 4 years ago

@cesargb Sorry for being pushy but have you had a chance to put some thought into this? I'd love to use this package but in it's current state it's not usable with this issue.

cesargb commented 4 years ago

@dannydinges This issue is fixed in the new version 2.3. I have done tests under postgresql 12.2 and all of them have passed.

Thanks.