search

cesarrew / ng2-currency-mask

A very simple currency mask directive that allows using a number attribute with the ngModel.
MIT License
235 stars 116 forks source link

Doesn't work in Angular 8 when import in AppModule. #133

Closed ericferreira1992 closed 5 years ago

ericferreira1992 commented 5 years ago

I'm migrating my application to version 8 of Angular, and I'm having problems when run my application. The application works fine when remove the CurrencyMaskModule. The Angular return the following error: image

But I mapped the error when the script of core.js is running, catching which module has trouble run. (See the return down below) image

I don't know exactly the reason of the problem, but it say that error is in this part of code from core.js: if (ngModuleType.ngModuleDef.id !== null) { Where ngModuleType.ngModuleDef is undefined.

I would very much like you to help me with this as I don't want to stop using your package. Thanks!

ozzpy commented 5 years ago

for me work perfec, can you show your code, you are report the core.js and not how you implement your code

ericferreira1992 commented 5 years ago

I just importing the module in my project. But I saw that many peoples who migrated their projects to version 8 of Angular had many problems when to use the Ivy, later I disable Ivy and the package work correctly. You can close this issue, this was my mistake due to the version upgrade.

eliteproxy7 commented 4 years ago

how can we make sure when we upgrade from angular 7 to 8 and want to run IVY that this error is resolved?