search

cesarrew / ng2-currency-mask

A very simple currency mask directive that allows using a number attribute with the ngModel.
MIT License
235 stars 116 forks source link

Flexibile Dependencies for Angular 12.2.x #163

Closed mrlonis closed 2 years ago

mrlonis commented 2 years ago

Allow other projects that use ng2-currency-mask to use higher version of Angular 12.2.x and rxjs 6.x.x

gustavocipriani commented 2 years ago

+1 to this @cesarrew Now that NodeJS 16 became the current LTS, a higher adoption of NPM 7 is to be expected,. Having the dependencies range correctly set up is going to become important as builds will start to break unless the users resort to options like using the "--legacy-peer-deps" flag.

mrlonis commented 2 years ago

I have already moved on to use a different currency mask... but I still care to see this one updated

mrlonis commented 2 years ago

tslib should also be updated to "^2.3.0" but I forgot to do it in this PR

gustavocipriani commented 2 years ago

tslib should also be updated to "^2.3.0" but I forgot to do it in this PR

Right. Also, I'm thinking,... wouldn't be better to use carets instead of tildes in the Angular packages so it still works when a new minor (for example, angular 12.3.0) is released?

gustavocipriani commented 2 years ago

I have already moved on to use a different currency mask... but I still care to see this one updated

Do you mind to share which one?

mrlonis commented 2 years ago

Honestly yes it would be better to use carets

mrlonis commented 2 years ago

I'm going to leave it up to the code maintainers to handle that decision though. Seems like they go inactive for months

vladkasianenko commented 2 years ago

Do you mind to share which one?

Do you mind to share which one?

mrlonis commented 2 years ago

I found great success with this one: https://www.npmjs.com/package/ngx-currency

cesarrew commented 2 years ago

Thanks guys. Fixed this problem in version 13.0.0.