cescoffier / vertx-completable-future

An implementation of CompletableFuture for Vert.x
Apache License 2.0
78 stars 28 forks source link

Consider to use provided scope for vertx-core #2

Closed bmsantos closed 7 years ago

bmsantos commented 7 years ago

I'm using this library with future graphql async library that uses Java's CompletableFuture. I'm also using vertx 3.3.3 and have to exclude vertx-core 3.3.2 from maven.

Setting the dependency scope to "provided" would remove the need for dependency exclusions in projects using vertx other than 3.3.2.

    <dependency>
      <groupId>io.vertx</groupId>
      <artifactId>vertx-core</artifactId>
      <scope>provided</scope>
    </dependency>
cescoffier commented 7 years ago

Just cut the 0.1.1 release with the fix. Should be in Maven central in a few minutes.

bmsantos commented 7 years ago

Thanks