search

cescoffier / vertx-completable-future

An implementation of CompletableFuture for Vert.x
Apache License 2.0
79 stars 29 forks source link

why exceptionally is not implemented in VertxCompletableFuture #42

Closed StarWindMoonCloud closed 3 years ago

StarWindMoonCloud commented 5 years ago

any good reasoning here, exceptionally is very handy to me.

cescoffier commented 5 years ago

It's just because I forgot. Fancy a PR?

StarWindMoonCloud commented 4 years ago

@cescoffier I took a look at the code, but not sure how to implement here, could you please help out?

AndierZ commented 4 years ago

I might be able to help. Let me take a poke at it. Btw this is great work. Kudos to the team and @cescoffier for creating this utility.

StarWindMoonCloud commented 4 years ago

so any update? @AndierZ

jayfeng0625 commented 3 years ago

I have got a branch with the implementation but I was unable to push due to permission. @cescoffier would you mind sharing some guidelines on how to contribute?

cescoffier commented 3 years ago

You need to fork the repository first (button on the top right in Github), push to a branch in your fork and then open a pull request (Github will display a message about that).