cescoffier / vertx-microservices-workshop

Vert.x Microservices Hand's on lab
http://escoffier.me/vertx-hol/
Apache License 2.0
331 stars 196 forks source link

Documentation fix #44

Closed nBhati closed 5 years ago

nBhati commented 5 years ago

INSTALL.md just mentions to copy parent pom to repository which doesn't install the pom and hence build of other module fails.

Please add below to documentation

mvn install:install-file -Dpackaging=pom -Dfile=~/.m2/repository/io/vertx/workshop/vertx-microservice-workshop/1.0-SNAPSHOT/vertx-microservice-workshop-1.0-SNAPSHOT.pom.xml -DpomFile=~/.m2/repository/io/vertx/workshop/vertx-microservice-workshop/1.0-SNAPSHOT/vertx-microservice-workshop-1.0-SNAPSHOT.pom.xml

cescoffier commented 5 years ago

Did you try with mvn install -N ?

nBhati commented 5 years ago

I tried mvn install -N but it didnt work. i had to manually install the parent pom in repository.

Thanks

cescoffier commented 5 years ago

odd, because that's exactly what mvn -N install is doing (installing the root pom). Anyway, can you open a PR?

nBhati commented 5 years ago

Hi @cescoffier,

I tried mvn -N install after removing dir path for parent pom and it worked. i have updated documentation as needed and raised PR.

Thanks