cesine / phonetisaurus

Automatically exported from code.google.com/p/phonetisaurus
0 stars 0 forks source link

phonetisaurus-align --thresh option not working #35

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Call phonetisaurus-align --thresh X
2.
3.

What is the expected output? What do you see instead?

I would expect the EM to stop when threshold is reached and not when we have 
done the max number of iterations. I think this just got lost or is not in my 
version.

What version of the product are you using? On what operating system?

0.8a

Centos 5

Please provide any additional information below.

I tried:

    cerr << "Starting EM..." << endl;
    float fChange = aligner.maximization(false);
    cerr << "Finished first iter..." << endl;
    for( int i=1; i<=FLAGS_iter && fChange > FLAGS_thresh; i++ ){
      cerr << "Iteration: " << i << " Change: ";
      aligner.expectation();
      fChange = aligner.maximization(false);
      cerr << fChange << endl;
    }

which seemed to do what was intended.

Original issue reported on code.google.com by sorin.io...@sovo-tech.com on 18 Feb 2015 at 7:21