search

cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
31 stars 18 forks source link

Ensure config.yaml app.routes matches that of config.yaml.defaults (in parent app) #191

Closed acrellin closed 3 years ago

acrellin commented 3 years ago

This PR addresses the issue where a local config.yaml falls behind config.yaml.defaults, leading to missing front-end route mappings, causing critical failures.

Closes https://github.com/skyportal/skyportal/issues/1531

pep8speaks commented 3 years ago

Hello @acrellin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:80: E501 line too long (82 > 79 characters) Line 25:80: E501 line too long (86 > 79 characters)

Comment last updated at 2021-02-02 06:23:42 UTC
dmitryduev commented 3 years ago

@acrellin weren't we using somewhere (on the CI?) a very minimalistic config? I may have dreamt it though...

acrellin commented 3 years ago

@dmitryduev test_config.yaml perhaps? That's very minimal, but this only checks the parent app's config.yaml (if specified) against its config.yaml.defaults

dmitryduev commented 3 years ago

ah, right, never mind then.

acrellin commented 3 years ago

Woops, thanks for catching that. Added deepdiff to requirements.txt now

dmitryduev commented 3 years ago

@acrellin the CI saw a walrus and freaked out -- gotta change the python version requirement on Travis. Or better still, ditch it for good as @dannygoldstein is suggesting and move to GA asap.

stefanv commented 3 years ago

@acrellin the CI saw a walrus and freaked out -- gotta change the python version requirement on Travis. Or better still, ditch it for good as @dannygoldstein is suggesting and move to GA asap.

I'm on it.

stefanv commented 3 years ago

@dmitryduev I think this is probably good to go.

dmitryduev commented 3 years ago

@stefanv @acrellin Hmm.. the CI failed on commit to master?..