cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
31 stars 18 forks source link

add custom accessibility query and fix permission checking in handlers #207

Closed dannygoldstein closed 3 years ago

dannygoldstein commented 3 years ago

This PR adds a custom UserAccessControl that allows developers to specify complex access permissions such as those required for group/stream access in SkyPortal as SQLalchemy Query objects.

It also fixes a bug where I was only automatically checking the permissions of objects that were being deleted instead of deleted, read, or updated.

pep8speaks commented 3 years ago

Hello @dannygoldstein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 639:80: E501 line too long (80 > 79 characters) Line 641:80: E501 line too long (80 > 79 characters) Line 687:80: E501 line too long (82 > 79 characters)

Comment last updated at 2021-03-17 23:13:30 UTC