cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
31 stars 18 forks source link

Explicitly set BaseMixin id to autoincrement #232

Closed kmshin1397 closed 3 years ago

kmshin1397 commented 3 years ago

This is the implicit default behavior when id is a single-column primary key, but autoincrement=True must be set explicitly when the id column is used as a part of a multiple-column primary key. This allows subclassed models to specify additional columns as part of the primary key.

https://docs.sqlalchemy.org/en/14/core/metadata.html?highlight=autoincrement#sqlalchemy.schema.Column.params.autoincrement

pep8speaks commented 3 years ago

Hello @kmshin1397! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 954:80: E501 line too long (89 > 79 characters)