search

cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
30 stars 18 forks source link

Add TypeScript service #260

Closed acrellin closed 2 years ago

pep8speaks commented 2 years ago

Hello @acrellin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 17:80: E501 line too long (80 > 79 characters)

Line 17:80: E501 line too long (80 > 79 characters) Line 29:80: E501 line too long (81 > 79 characters)

Comment last updated at 2021-10-19 22:35:44 UTC
stefanv commented 2 years ago

With the two-step process, do we have a guarantee that the webpack service will run late enough to catch the transpiled sources? If not, we should write out a sentinel file to let that service know that tsc is done.

acrellin commented 2 years ago

With the two-step process, do we have a guarantee that the webpack service will run late enough to catch the transpiled sources? If not, we should write out a sentinel file to let that service know that tsc is done.

@stefanv My thought on this was simply to always run webpack in --watch mode. Any potential issues with that?

acrellin commented 2 years ago

@stefanv The bundle size will be unaffected by combining --mode=production and --watch, we'll just be simply keeping the daemon alive to watch for any new changes (e.g. when tsc completes)

stefanv commented 2 years ago

Yeah, not a big deal I think.

acrellin commented 2 years ago

@stefanv Great, I've added that. Want to take a look?

stefanv commented 2 years ago

Looks like the test suite on master is unhappy :thinking: