search

cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
31 stars 18 forks source link

Refactor models #261

Closed stefanv closed 2 years ago

pep8speaks commented 2 years ago

Hello @stefanv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 170:80: E501 line too long (82 > 79 characters)

Line 31:80: E501 line too long (82 > 79 characters) Line 77:80: E501 line too long (80 > 79 characters) Line 85:80: E501 line too long (82 > 79 characters) Line 88:80: E501 line too long (84 > 79 characters) Line 95:80: E501 line too long (82 > 79 characters) Line 127:80: E501 line too long (82 > 79 characters) Line 130:80: E501 line too long (84 > 79 characters) Line 154:80: E501 line too long (82 > 79 characters) Line 157:80: E501 line too long (84 > 79 characters) Line 237:80: E501 line too long (83 > 79 characters) Line 260:80: E501 line too long (83 > 79 characters)

Line 67:80: E501 line too long (83 > 79 characters)

Line 91:80: E501 line too long (108 > 79 characters) Line 115:80: E501 line too long (84 > 79 characters)

Comment last updated at 2021-10-22 20:27:28 UTC
stefanv commented 2 years ago

The real test will be against SkyPortal, I suppose.

acrellin commented 2 years ago

Thanks @stefanv! Have you tested this locally within SkyPortal?

stefanv commented 2 years ago

Yes, it's not entirely happy, but in quite an obscure way. Looking at it.

guynir42 commented 2 years ago

@stefanv is this done? I think on SP it was completed a while ago...

stefanv commented 2 years ago

No, we ran into difficulties we could not debug at the time. Will have to re-attempt.