Boolean get_query_argument

[guynir42]

We need to inherit get_query_handler to deal with situations where the expected output is a boolean, not a string.

Example: do_something = self.get_query_argument("doSomething", False) followed by if do_something: will do the following:

• If the argument doSomething is not given in the query, return False, which is desired behavior.
• If the argument is given as "True", returns the string "True" then the if will evaluate it as true. Desired behavior.
• If the argument is given as "False" it returns the string "False" which the if takes as true. This is the wrong behavior.

Instead, we override the get_query_argument function to act differently if given a default boolean. In that case, it will interpret any of the following inputs: ['true', 't', 'yes', '1'] (in a case insensitive manner) as true. All other values are interpreted as false.

[pep8speaks]

Hello @guynir42! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-02-18 20:02:57 UTC

[guynir42]

@stefanv ready for re-review.

[stefanv]

It's a bit scary that we don't have tests for baselayer :/ Fortunately, it's well tested throug SkyPortal. Thanks @guy.