search

cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
30 stars 18 forks source link

User model - Affiliations #328

Closed Theodlz closed 1 year ago

Theodlz commented 2 years ago

This PR adds affiliations to the user model. The affiliations are stored as a list of strings, which can be displayed on the frontend and used to write scientific papers or circulars for example.

A WIP PR on SkyPortal : https://github.com/skyportal/skyportal/pull/3092 uses this to display it on the frontend.

Theodlz commented 2 years ago

Hi @profjsb. I renamed the branch affiliations just to make it more clear but that closed the previous PR. I added your suggestion and opened a WIP PR on SkyPortal.

Theodlz commented 2 years ago

Maybe add an example affiliation in the doc string?

Done @guynir42 !

Theodlz commented 2 years ago

By the way, do you think I could have the permissions to run the GA ?

guynir42 commented 2 years ago

@stefan can probably add your permissions to the repo.

guynir42 commented 2 years ago

Note that you will need to add a PR on skyportal with a migration script (and I assume some code to display/edit affiliations somewhere).

guynir42 commented 2 years ago

Note that you will need to add a PR on skyportal with a migration script (and I assume some code to display/edit affiliations somewhere).

Sorry I noticed there's already a skyportal PR as well.

mcoughlin commented 1 year ago

@guynir42 @Theodlz Can we coordinate this today?

Theodlz commented 1 year ago

That would be great. As soon as baselayer's PR is in. I can pin baselayer main on the skyportal PR

guynir42 commented 1 year ago

@mcoughlin @Theodlz sure but I'm not sure what we need to coordinate. If this is ready (and passes skyportal tests) then we should merge it and then have your PR pin this version of baselayer. If that is ready then there's no reason not to merge. I would be extra careful to make sure the skyportal version correctly migrates the changes in baselayer!

Theodlz commented 1 year ago

Hi @guynir42 ! I think that's what michael meant by coordinating. Just making sure to pin the right baselayer on my SP pr as soon as its in. When it comes to the migrations, it think it should be ok ? I updated the script, lets see if the migration tests are all green.

mcoughlin commented 1 year ago

@guynir42 ah by coordinate I just meant exactly that, I.e it will require that the SP PR go in so that the migration is in. If it was to get pinned without the migration we would be in trouble.