search

cesium-ml / baselayer

Fully customizable (scientific, compute-intensive) web application template
http://cesium-ml.org/baselayer/
30 stars 18 forks source link

SQLAlchemy 2.0 #349

Closed mcoughlin closed 1 year ago

mcoughlin commented 1 year ago

This PR updates SQLAlchemy to 2.0.

mcoughlin commented 1 year ago

@guynir42 It is Engine(postgresql://skyportal:***@localhost:5432/skyportal)

Theodlz commented 1 year ago

This looks good. I played around with the associated SkyPortal PR and I didn't notice any misbehavior so far. At least for the Baselayer part of this SQLAlchemy update, it deserves a LGTM!

mcoughlin commented 1 year ago

Ok so @Theodlz is happy and we can most easily test effects of sqlalchemy in skyportal. Will pin this there. Can always revert this.

stefanv commented 1 year ago

Could you please also patch up the template_app so it runs without warnings under 2.0?

https://github.com/cesium-ml/baselayer/actions/runs/4027542431/jobs/6923392520