search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
671 stars 101 forks source link

Mock out additional readthedocs libraries #123

Closed bnaul closed 8 years ago

bnaul commented 8 years ago

Some libraries were already present on Drone (e.g. requests) and not readthedocs; from now on Drone should fail whenever readthedocs is missing a dependency or mock library.

Also fixes a docstring indentation warning.

acrellin commented 8 years ago

:+1:

acrellin commented 8 years ago

stefanv: :+1:

stefanv commented 8 years ago

I like how I have become a Jeff Dunham special.

stefanv commented 8 years ago

Also, this PR is going to come and bite us in the ass, but at least we'll know it when it happens. Or perhaps we can build a small tool to generate a list of all external imports automatically?

acrellin commented 8 years ago

stefanv: :+1:

On Thursday, December 17, 2015, Stefan van der Walt < notifications@github.com> wrote:

Also, this PR is going to come and bite us in the ass, but at least we'll know it when it happens. Or perhaps we can build a small tool to generate a list of all external imports automatically?

— Reply to this email directly or view it on GitHub https://github.com/mltsp/mltsp/pull/123#issuecomment-165702557.

acrellin commented 8 years ago

:wink:

bnaul commented 8 years ago

¯_(ツ)_/¯

acrellin commented 8 years ago

@bnaul let's look into building a tool that auto-generates a :+1: from Stefan as soon as one of us creates a PR.

On Friday, December 18, 2015, Brett Naul notifications@github.com wrote:

¯(ツ)/¯

— Reply to this email directly or view it on GitHub https://github.com/mltsp/mltsp/pull/123#issuecomment-165857152.

stefanv commented 8 years ago

What have I done.