search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Feature meta data #206

Closed stefanv closed 7 years ago

acrellin commented 7 years ago

Is this a synthesis of all of our open pull requests? ☺️

acrellin commented 7 years ago

Nice! Like the feature category stuff. I'll push on the tags functionality Monday and Tuesday.

stefanv commented 7 years ago

Yes, I blended them all together to see how they worked :) Turns out, pretty well! I then made sure the docs get generated correctly, etc. I'm still not quite happy with the documentation for the features---it doesn't quite feel right. Perhaps you have some ideas on how to improve that.

acrellin commented 7 years ago

I'll need more than "doesn't quite feel right" to know how to refactor it to your liking.

On Friday, October 14, 2016, Stefan van der Walt notifications@github.com wrote:

Yes, I blended them all together to see how they worked :) Turns out, pretty well! I then made sure the docs get generated correctly, etc. I'm still not quite happy with the documentation for the features---it doesn't quite feel right. Perhaps you have some ideas on how to improve that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cesium-ml/cesium/pull/206#issuecomment-253967025, or mute the thread https://github.com/notifications/unsubscribe-auth/AG5TTe1R1kshwf4pjBYVT8m3zYxqFRveks5q0HfEgaJpZM4KXlTr .

acrellin commented 7 years ago

Where are we at on this one?

stefanv commented 7 years ago

We're good to go, I think.

acrellin commented 7 years ago

Ok, feel free to merge.