Testcoverage - Githubissues

cesium-ml / cesium

Machine Learning Time-Series Platform

Other

670 stars 101 forks source link

Testcoverage #215

Closed arkwave closed 7 years ago

arkwave commented 7 years ago

Added in tests for test_cadence_features and test_transformation.py.

coverage for cadence_features up to 92% from 78%
coverage for transformation.py up top 83% from 68%

Added in line in cadence_features.py to account for python lists incorrectly being passed in as input.

stefanv commented 7 years ago

Please rebase on master to resolve conflict.

bnaul commented 7 years ago

Can you also: 1) fix the line lengths and other PEP8 violations (the flake8 or pep8 utilities will show you the problems) 2) edit the title of this PR to be more informative

stefanv commented 7 years ago

@bnaul Want to take a look?

bnaul commented 7 years ago

Still needs PEP8 fixes (at least for line lengths, some of which are super long). Otherwise looks good 👍 .

bnaul commented 7 years ago

:+1: @stefanv?

stefanv commented 7 years ago

Thanks, @arkwave !