search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Port nose to pytest (fixes #242) #245

Closed hatsy closed 7 years ago

hatsy commented 7 years ago

High level description

I ported all test to use pytest instead of nose. I tried to use the equivalent functions in pytest without changing the structure of the tests. Also updated Travis build to use pytest.

Testing

All tests pass locally with pytest and nose uninstalled. Travis build passes.

codecov-io commented 7 years ago

Codecov Report

Merging #245 into master will decrease coverage by 1.99%. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
- Coverage   94.12%   92.12%   -2%     
=======================================
  Files          43       45    +2     
  Lines        2195     2197    +2     
  Branches      272      222   -50     
=======================================
- Hits         2066     2024   -42     
- Misses         73      118   +45     
+ Partials       56       55    -1
Impacted Files Coverage Δ
cesium/tests/test_transformation.py 100% <ø> (ø) :arrow_up:
cesium/tests/test_predict.py 100% <ø> (ø) :arrow_up:
cesium/datasets/tests/test_datasets.py 92% <100%> (-4.25%) :arrow_down:
cesium/tests/test_featureset.py 100% <100%> (ø) :arrow_up:
cesium/tests/test_time_series.py 100% <100%> (ø) :arrow_up:
cesium/tests/test_data_management.py 100% <100%> (ø) :arrow_up:
cesium/tests/test_util.py 100% <100%> (ø) :arrow_up:
cesium/tests/test_featurize.py 99.35% <100%> (+1.15%) :arrow_up:
cesium/util.py 85.1% <0%> (-2.13%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30f59d5...c10191a. Read the comment docs.

bnaul commented 7 years ago

This looks great! Just needs a rebase (since .drone got moved to .travis) and then should be good to go.

bnaul commented 7 years ago

My PR to your branch (https://github.com/hatsy/cesium/pull/1) makes 1 small change that is possible now that we're using pytest; it also does the rebase w/ master so if you merge that we should be all set.