search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Add flag for suppressing exceptions during featurization #256

Closed bnaul closed 7 years ago

bnaul commented 7 years ago

@aricq wanna take a look and make sure this behaves like you wanted?

pep8speaks commented 7 years ago

Hello @bnaul! Thanks for submitting the PR.

Line 71:13: E731 do not assign a lambda expression, use a def

Line 267:5: E306 expected 1 blank line before a nested definition, found 0

acrellin commented 7 years ago

:+1: looks good, thanks @bnaul

codecov-io commented 7 years ago

Codecov Report

Merging #256 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   92.77%   92.85%   +0.07%     
==========================================
  Files          35       35              
  Lines        1897     1917      +20     
  Branches      245      248       +3     
==========================================
+ Hits         1760     1780      +20     
  Misses        100      100              
  Partials       37       37
Impacted Files Coverage Δ
cesium/tests/test_featurize.py 100% <100%> (ø) :arrow_up:
cesium/featurize.py 97.52% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd45874...561cdab. Read the comment docs.