search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Update load_featureset to handle filler strings for empty channel values #264

Closed acrellin closed 6 years ago

acrellin commented 6 years ago

When reading a CSV into a pandas DataFrame (pd.read_csv), empty channel values are filled with a string ("Unnamed ...") which, when saved and then loaded with load_featureset, breaks the type-casting of channel values from string to int, unless empty. This changes the check from whether it's empty to whether it's a digit, to handle the above-specified case.

codecov-io commented 6 years ago

Codecov Report

Merging #264 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          34       34           
  Lines        1903     1903           
  Branches      239      239           
=======================================
  Hits         1772     1772           
  Misses         97       97           
  Partials       34       34
Impacted Files Coverage Δ
cesium/featurize.py 97.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11e9d66...d90d491. Read the comment docs.