cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Dask version must be < 0.20.0 #276

Closed milesial closed 5 years ago

milesial commented 5 years ago

When using pip install cesium, by default dask 0.20.0 was installed.

In the dask 0.20.0 changelog there is :

Raise an error on the use of the get= keyword and set_options

However, featurize_time_series and featurize_ts_files (maybe other functions) still use the get keyword, so we get the error :

TypeError: The get= keyword has been removed.

Please use the scheduler= keyword instead with the name of the desired scheduler like 'threads' or 'processes'

The requirements.txt was changed to limit the dask version to one before 0.20.0

Now we only get a warning

UserWarning: The get= keyword has been deprecated. Please use the scheduler= keyword instead with the name of the desired scheduler like 'threads' or 'processes'

PS: The warning appeared in dask 0.18.0, so we can set <0.18.0 if we don't want the warning

stefanv commented 5 years ago

A better solution may be to follow the advice in the message. I.e., change to a newer version of dask as a minimal dependency, and use the scheduler keyword instead. Would you like to try and make such a PR? If not, I can try and fix it tomorrow.

milesial commented 5 years ago

Okay I will do it this evening (~UTC)

milesial commented 5 years ago

Fixed by https://github.com/cesium-ml/cesium/pull/278