search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
670 stars 101 forks source link

Compatibility with dask 0.20 : 'get' keyword replaced with 'scheduler' #278

Closed milesial closed 5 years ago

milesial commented 5 years ago

Related to https://github.com/cesium-ml/cesium/pull/276 https://github.com/cesium-ml/cesium/issues/277.

I think this is the only places where get was used. I updated the requirements.txt.

stefanv commented 5 years ago

@acrellin Looks like CI is failing because of a Pandas issue. Can you confirm? https://travis-ci.org/cesium-ml/cesium/jobs/460408199

acrellin commented 5 years ago

@stefanv yep, looks like pandas v0.23.0 introduced some API changes - will push up a patch shortly.

acrellin commented 5 years ago

@stefanv Also note that "Starting January 1, 2019, pandas feature releases will support Python 3 only."

acrellin commented 5 years ago

I've pushed a patch to master to address the pandas-related bug. Please rebase.

milesial commented 5 years ago

It seems dask has dropped support for Python 3.4 in 0.19.0 (http://docs.dask.org/en/latest/changelog.html). This causes the travis job for 3.4 to fail.

acrellin commented 5 years ago

@milesial Okay, I'll remove Python 3.4 from the test matrix

acrellin commented 5 years ago

@milesial Okay, go ahead and try rebasing again - I've removed 3.4 from the test matrix.

stefanv commented 5 years ago

@acrellin Looks like we need a newer version of NumPy now; if I read the test logs correctly? Also note that we can rebase on behalf of contributors.

milesial commented 5 years ago

@acrellin The commits seem to not appear in the master branch, maybe a force push deleted it ? In this state, the master does not have the fix of the get= keyword and still errors.

acrellin commented 5 years ago

@milesial thanks for catching this and bringing it to my attention. I've added the relevant commit from this PR to the master branch.