search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
671 stars 101 forks source link

pinned scikit-learn #289

Closed paulkerry1 closed 4 years ago

paulkerry1 commented 4 years ago

Hi Please consider not pinning scikit-learn==0.20.0 as done in... https://github.com/cesium-ml/cesium/blob/master/requirements.txt

Pinning the older release of scikit-learn is causing problems on systems that require the latest version of scikit-learn for other python packages.

This is using python 3.7.3

Cheers Paul.

stefanv commented 4 years ago

@paulkerry1 Sorry for the delay in responding; we can certainly unpin scikit-learn. @acrellin Do you have a moment to take a look?

acrellin commented 4 years ago

@paulkerry1 this is now fixed in the latest master and in the newly released v0.9.12

acrellin commented 4 years ago

Fixed in https://github.com/cesium-ml/cesium/commit/fc3230bbfc0a246f83652d6f3523adc58d306e05

paulkerry1 commented 4 years ago

Great - thanks very much. Paul.