search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
671 stars 101 forks source link

Fix bug causing feature test failures in Python3 #67

Closed bnaul closed 9 years ago

bnaul commented 9 years ago

type('')==bytes evaluates to True in Python2, and False in Python3. This was causing some variable to never be set, which eventually led to various silent errors downstream; the ultimate result was the uncertainty values not being properly loaded from the data, which caused all features which used those to have the wrong values.

stefanv commented 9 years ago

Thanks, Brett! I'm going to merge this for now. In the long run, we should probably get rid of all such types of checks. I cannot see why we would need them.