search

cesium-ml / cesium

Machine Learning Time-Series Platform
Other
671 stars 101 forks source link

Expand model options #90

Closed acrellin closed 9 years ago

acrellin commented 9 years ago

Offer multiple models and expose their parameters in the browser; generalize class/target concept to include regression data; streamline/update function signatures; expand unit tests, etc.

bnaul commented 9 years ago

Everything looks good to me! :+1:

stefanv commented 9 years ago

Big piece of work! Thanks, Ari. I like the design you've introduced to describe the model parameters.

The only important comment was to avoid generating HTML inside our code, if possible, and to make sure all values displayed to the user are escaped, otherwise all sorts of nasty attacks become possible.

acrellin commented 9 years ago

@stefanv, thanks for the helpful feedback. Regarding generating HTML code in the backend, I definitely agree about avoiding this, but it's not new to this PR, so I'll open an issue and address that separately so it doesn't hold up this PR.

stefanv commented 9 years ago

:guitar: