search

cesium / atomic

⚛️ De-engineered bifurcarted intranet
MIT License
40 stars 8 forks source link

refactor: enhance enrollments schema #417

Closed danielsp45 closed 1 year ago

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request contains a refactor of the enrollments schema in the project. It includes renaming Enrollment to ActivityEnrollment for clarity in the system. Additionally, a new EventEnrollment schema was introduced for tracking event enrollment separate to activity enrollment. With the renaming of the schemas, the associated files, links, and tests also underwent renaming to match. The seed file was also edited to create ActivityEnrollment instead of Enrollment. Furthermore, a new migration file was added to create the event_enrollments table in the database. Overall, this change would enhance the readability and organization of the enrollments in the system and prepare the structure for the new feature of event enrollment.

danielsp45 commented 1 year ago

I think we should also change the function names, for example:

list_enrollments to list_activity_enrollments so everything stays under the same context

I think that's a bit redundant because you will do Activities.list_enrollments() and then Events.list_enrollments(). It will already be self explanatory which one I'm referring to.