search

cesium / atomic

⚛️ De-engineered bifurcarted intranet
MIT License
39 stars 8 forks source link

refactor: remove breadcrumbs navigation #425

Closed joaodiaslobo closed 11 months ago

joaodiaslobo commented 11 months ago

Remove the breadcrumb entries from all pages

reviewpad[bot] commented 11 months ago

AI-Generated Summary: This pull request contains changes across multiple files, primarily focusing on refactoring breadcrumb navigation within the handle_params functions of various live view modules. The common pattern amongst these changes is the removal of hardcoded lists, called entries, containing breadcrumb link details, and their subsequent assignment to breadcrumb_entries.

Files affected are within the AtomicWeb module, including but not limited to: announcement_live/show.ex, board_live/new.ex, home_live/index.ex, organization_live/index.ex, organization_live/show.ex, announcement_live/edit.ex, activity_live/edit.ex, membership_live/index.ex, department_live/show.ex, organization_live/edit.ex, profile_live/show.ex, partner_live/show.ex, speaker_live/index.ex, scanner_live/index.ex, activity_live/index.ex, board_live/index.ex, speaker_live/show.ex, profile_live/edit.ex, department_live/index.ex, announcement_live/index.ex, partner_live/index.ex, membership_live/edit.ex and activity_live/show.ex.

This refactor not only removes the creation of these lists but also their assignment to socket. This set of changes could suggest a change in how breadcrumb navigation is handled within the application, potentially with a move towards a more dynamic creation or complete removal.

While this removal of associated breadcrumb coding simplifies the individual handle_params functions, developers should ensure these changes do not adversely affect the user interface if it was reliant on the breadcrumb_entries assignment to the socket. Apart from this specific pattern of removal, the rest of the code within the handle_params functions largely remains unchanged.