search

cesium / atomic

⚛️ De-engineered bifurcarted intranet
MIT License
39 stars 8 forks source link

feat: enhance reset password pages #437

Closed joaodiaslobo closed 11 months ago

joaodiaslobo commented 11 months ago

Improves password reset pages frontend, also makes account recovery via username possible. Adds password change page, resolves #428 .

image image image

reviewpad[bot] commented 11 months ago

AI-Generated Summary: This pull request encompasses extensive modifications related to user password management in the AtomicWeb application, providing new features for account recovery, password modification, and enhancing user interface and experience.

Significant changes include introducing a new module AtomicWeb.UserChangePasswordView associated with changing the user password functionality. Several files, including lib/atomic_web/controllers/user_settings_controller.ex, lib/atomic_web/views/user_settings_view.ex, and test/atomic_web/controllers/user_settings_controller_test.exs among others, have been deleted, indicating a shift in the approach to functionalities they covered.

Enhancements can be seen in the user_reset_password_controller.ex, where new functionalties enable users to recover accounts using emails as well as usernames. The user interface for the password resetting functionality has been upgraded in the new.html.heex template and edit.html.heex file under the user_reset_password directory. Opting for better readability and designs, the texts, icons, and other graphical content have undergone comprehensive modifications.

Tests have also been updated in line with the changes in password management. Changes include renaming test cases to reflect feature adjustments, adding new test scenarios, and removing redundant tests in the light of refactoring.

A few noticeable file additions include creating a new form for handling password changes and test/atomic_web/controllers/user_change_password_controller_test.exs to cover routes for handling the password modification request.

Overall, this set of changes suggest a shift from old user setting routes to new ones, revisions in warnings and error messages, and a more versatile input handling by now accepting both emails and user slug. The changes aim to improve user navigation and the user interface experience.