cesmix-mit / InteratomicPotentials.jl

Contains methods and types for a variety interatomic potentials.
MIT License
27 stars 6 forks source link

potential fix for #21 #22

Closed jrdegreeff closed 2 years ago

jrdegreeff commented 2 years ago

My approach to fixing this is to filter out neighbors early such that partilce j is included in particle i's neighbor list only if j > i. This is consistent with the performance engineering principle of filtering early. See the changed test case for an example.

Note that I have not yet changed the SNAP version of the neighborlist function. I wanted to confirm that this behavior is desirable before doing that.